Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved version of adding utterances #289

Merged
merged 10 commits into from
Jun 12, 2021
Merged

Improved version of adding utterances #289

merged 10 commits into from
Jun 12, 2021

Conversation

im-coder-lg
Copy link
Contributor

@im-coder-lg im-coder-lg commented Jun 10, 2021 •
edited
Loading

The last PR I made was messed up. So, I fixed those errors and even tested it on Gitpod and it works like a charm. I even updated the readme, added a section for comments in the config.yml file.
live demo at my site
To Dos here:

  • make sure that if utterances section is full, only then it will load Utterances comments
  • do a small change in the config
  • change PR from draft to ready for review after doing task 2

last task:

  • add label line in config and utterances code.

@im-coder-lg im-coder-lg marked this pull request as ready for review June 10, 2021 04:20
@im-coder-lg
Copy link
Contributor Author

Everything works now.

@im-coder-lg
Copy link
Contributor Author

the label is optional

@im-coder-lg
Copy link
Contributor Author

all done and fully ready. 👍

danisztls
danisztls reviewed Jun 10, 2021
View reviewed changes
Copy link
Contributor

@danisztls danisztls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. 🚀

@im-coder-lg
Copy link
Contributor Author

Looking good. rocket

thanks :octocat:

@im-coder-lg
Copy link
Contributor Author

a live demo of utterances is at my site.

sylhare
sylhare reviewed Jun 10, 2021
View reviewed changes
Copy link
Owner

@sylhare sylhare left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I added some tiny comments ;)

README.md Outdated Show resolved Hide resolved
_layouts/post.html Outdated Show resolved Hide resolved
im-coder-lg
im-coder-lg commented Jun 11, 2021
View reviewed changes
Copy link
Contributor Author

@im-coder-lg im-coder-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since cusdis and disqus have only one line, ie cusdis_app_id and disqus_shortname, it is of no use to add them here. If you see Utterances, it has 3 lines plus 1 optional. So, Utterances has to work with the repo name to store the comments as issues, an issue term such as title which will make sure that the issue name is the blog title and theme for the theme for utterances. These three code lines are compulsory for .Utterances to work successfully.

_layouts/post.html Outdated Show resolved Hide resolved
@im-coder-lg
Copy link
Contributor Author

im-coder-lg commented Jun 11, 2021 •
edited
Loading

since Cusdis and Disqus have only one line, ie cusdis_app_id and disqus_shortname, it is of no use to add them here. If you see Utterances, it has 3 lines plus 1 optional. So, Utterances has to work with the repo name to store the comments as issues, an issue term such as title which will make sure that the issue name is the blog title and theme for the theme for utterances. These three code lines are compulsory for Utterances to work successfully.

You visit my personal blog, open the latest one and scroll down to comment in Utterances. Then, click here and go to the Issues section. Click the latest issue and you will see that the issue is stored on a specific repo, with a specific title and Utterances has a specific theme at the blog.

@im-coder-lg
Copy link
Contributor Author

Those three are required for Utterances to load perfectly.

@im-coder-lg
Copy link
Contributor Author

im-coder-lg commented Jun 11, 2021 •
edited
Loading

Disclaimer

This video file here is a live demo of Utterances. And, Sylhare, don't get shocked, it was all done on my fork of Type-on-Strap on Gitpod.

Demo:

utterances.test.mp4

all things are good, and if you really want to see the issue, click here

@im-coder-lg
Copy link
Contributor Author

ping @sylhare @danisztls

@im-coder-lg
Copy link
Contributor Author

please check the attachment 🆙

sylhare
sylhare reviewed Jun 11, 2021
View reviewed changes
Copy link
Owner

@sylhare sylhare left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to try it, before merging ;)

@im-coder-lg
Copy link
Contributor Author

Ok, and remember to fill up the first three lines in Utterances' code. It is added in the Readme too

@sylhare sylhare merged commit 3afe5ad into sylhare:master Jun 12, 2021
@sylhare sylhare mentioned this pull request Jun 12, 2021
Merged
@sylhare
Copy link
Owner

sylhare commented Jun 12, 2021

I merged your PR good job, thanks @coder-lg !! 😄 🎉

@im-coder-lg
Copy link
Contributor Author

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylhare sylhare sylhare left review comments

@danisztls danisztls danisztls left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@im-coder-lg @sylhare @danisztls